406 - the docket number will reset to 1 on a new year #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadlerw
approved these changes
Jan 7, 2019
|
Very interesting! I'm glad our work spanned the new year so that this could be spotted early. |
dknesek
reviewed
Jan 8, 2019
| return client.updateConsistent({ | ||
| applicationContext, | ||
| TableName: TABLE, | ||
| Key: { | ||
| pk: 'docketNumberCounter', | ||
| sk: 'docketNumberCounter', // TODO: set sk by the year, i.e. 2018 | ||
| pk: `docketNumberCounter-${year}`, |
There was a problem hiding this comment.
@codyseibert Why is the format of a docket number a rule enforced by the persistence gateway? Or am I misunderstanding what's really going on here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the docket number did not reset to 1 on a new year; this pr creates a new index with the year as the suffix to fix that